dwsmith1983 commented on issue #6970: URL: https://github.com/apache/datafusion-comet/issues/6970#issuecomment-6168537938
More from working on this: - `element_at` over a nullable array has the same gap, for example `element_at(a1, CAST(1 div i AS INT)), element_at(a2, CAST(1 div i AS INT))`. - Evaluating the key eagerly through `withNullShortCircuit`, as `GetMapValue` does, fixes these shapes but makes `map_from_arrays` raise where Spark does not when the arguments share only a harmless piece. The existing `map_from_arrays short-circuits null keys` test in `CometMapExpressionSuite` fails that way: the keys and values share `k = 0`, Spark hoists only that, and still skips `1 / k` on the rows whose keys are NULL. It also raises with subexpression elimination off, which is #6972. So the plan is to decline these shapes and fall back to Spark instead, using the check #5867 adds for dispatched expressions, in the same change as #6971 once #5867 is in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
