parthchandra commented on PR #6860:
URL:
https://github.com/apache/datafusion-comet/pull/6860#issuecomment-6158957597
[NIT] One optional test suggestion. The two new tests that pin the
class-sharing mechanism in `CachedBatchRowIteratorSuite.scala:137` ("readers of
one layout share a class and read their own batches", helper `wideTypes` at
:187) only use int, bigint and string. Nested schemas are the whole motivation
for this change, so it would be nice to add one case with a struct that holds
an array and a map, so the shared-reader-with-cloned-batches path is pinned for
nested values too. Low priority - the end-to-end nested coverage already exists
in `CometInMemoryCacheSuite` and runs on this PR, so this is just a direct
white-box pin on the new mechanism for the case it was built for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
