andygrove commented on PR #6852: URL: https://github.com/apache/datafusion-comet/pull/6852#issuecomment-6148969178
@viirya thanks for the review. I've answered the dual-format question inline. On the backport, I'd keep this on main. On branch-1.1 the crash needs Comet's cache serializer, which `spark.comet.exec.inMemoryCache.enabled` installs, plus `spark.comet.exec.transitionRevert.enabled`, and both are off by default there. It isn't a regression either. 1.0 had no Arrow cache serializer, so with Spark's default one the cache never asked a reverted stage for columnar output. The pick also conflicts in both files, so it would be a manual port. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
