LinSimon-901101 opened a new pull request, #6930: URL: https://github.com/apache/datafusion-comet/pull/6930
## Which issue does this PR close? Closes #6849. ## Rationale for this change Native TIMESTAMP outputs must retain the canonical `UTC` Arrow timezone label, while TIMESTAMP_NTZ outputs must remain unlabeled. Value-only result comparisons can miss incorrect labels, including a semantically equivalent `Etc/UTC` label. ## What changes are included in this PR? Add three SQL fixtures covering timestamp-producing datetime expressions, supported casts (including Boolean and TIMESTAMP_NTZ), and `convert_timezone`, across `UTC`, `Etc/UTC`, and `America/Los_Angeles` session timezones. The fixtures compare native outputs with scanned timestamp references and exercise downstream timestamp consumers, with explicit native-plan assertions. Inputs include nulls, pre-epoch values, and winter/summer/DST cases. `convert_timezone` coverage requires Spark 3.5 or newer. ## How are these changes tested? - Local execution: all nine fixture/timezone cases pass on the default profile. - Mutation checks: changing a native TIMESTAMP output label from `UTC` to `Etc/UTC`, or incorrectly adding `UTC` to a TIMESTAMP_NTZ cast, makes the relevant three timezone cases fail. The mutations were reverted before final validation. - The unmodified repository Comet CI workflow passed in the fork: [full CI run](https://github.com/LinSimon-901101/datafusion-comet/actions/runs/38341609955), with 131 successful jobs, seven expected non-test skips, and successful Required Checks. - All six expressions jobs (five Linux Spark profiles and macOS) passed. The new fixtures account for 51 executed passing cases and three expected Spark 3.4 version skips. The full CI run tested validation commit `0799ea1789a1c2e4d5864e6540f898a73d163967`, which contains these identical SQL fixtures plus the test fix from now-merged #6902 and fork-only supplemental workflows. This PR includes only the three SQL fixtures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
