viirya commented on PR #6716: URL: https://github.com/apache/datafusion-comet/pull/6716#issuecomment-6131147184
Thanks @grorge123 for catching the expressions serialized after the operator's conversion. I missed that a missing shared set was read as an empty one. Making that case skip nothing is the right default, because anything serialized outside an operator's conversion now keeps main's eager evaluation. The scopes in 3090d859a and 0e49f1c03 also match how Spark evaluates each piece. Hash and range partitioning keys go through one `UnsafeProjection`, so one subexpression elimination pass covers them. `TakeOrderedAndProjectExec` compares sort keys through `LazilyGeneratedOrdering`, which doesn't eliminate subexpressions, and projects `projectList` separately. Still LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
