asolimando commented on PR #26094: URL: https://github.com/apache/datafusion/pull/26094#issuecomment-6124114939
Thanks @zhuqi-lucas for this extra round of benchmarking. TPC-DS planning has shown improvements in all runs ranging from 2% to 4%, which is good but it is also likely a lower bound, because the benchmark tables are empty (each statistics computation is cheap, as discussed above). The other benchmarks aren't really affected and are within noise within noise: the logical planning benchmarks, which this PR does not touch, move by a similar amount. Unless @jayzhan211 has further comments, I think this is good to go, but happy to improve it further if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
