2010YOUY01 commented on issue #26171: URL: https://github.com/apache/datafusion/issues/26171#issuecomment-6120402017
> 3\. I feel like this is the core challenge that we need to address -- how to decide to push back (or accept) code to handle shapes that the built in pipeline never covers. @alamb To identify optimization coverage beyond what the core needs, perhaps we can look at test line coverage from sqllogictest only. If certain optimization logic is only reachable through unit tests, that might indicate extra coverage. WIP in - https://github.com/apache/datafusion/pull/26219 Regarding whether to push back or accept, I guess we'll have to look at concrete cases first. Extension users should be able to explain why certain optimization coverage can only (or is better) implemented inside built-in rules. Otherwise, if there's no clear justification, that's a strong signal of downstream hacks being propagated upstream. I'll try to address those points in the later reworked doc PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
