Tyagiquamar commented on code in PR #25949:
URL: https://github.com/apache/datafusion/pull/25949#discussion_r4244827492
##########
datafusion/sql/src/unparser/expr.rs:
##########
@@ -1261,10 +1261,16 @@ impl Unparser<'_> {
.to_string()
};
+ let tz = if tz.is_some() {
+ &Some(Arc::from("+00:00"))
+ } else {
+ &None
+ };
Review Comment:
Good catch, thank you! Updated to pass &tz.cloned() directly to
self.dialect.timestamp_cast_dtype(&time_unit, &tz.cloned()) without any
intermediate synthetic assignment. Verified with cargo fmt --check -p
datafusion-sql, cargo clippy -p datafusion-sql, and cargo test -p
datafusion-sql --lib unparser::expr::tests in Docker (all 36 unparser expr
tests passed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
