ShayanGho commented on code in PR #25787:
URL: https://github.com/apache/datafusion/pull/25787#discussion_r4244572231
##########
datafusion/physical-optimizer/src/ensure_requirements/enforce_distribution.rs:
##########
@@ -1210,6 +1210,19 @@ fn enforce_distribution_relationships(
}
};
+ // Reject a reference when another child in the co-partitioned group
Review Comment:
Makes sense, done. The reference is now rejected only when it is below the
`CollectLeft` thresholds and another input is above them. Inputs on the same
side of the thresholds keep the reference, so only one side is shuffled
(`range_hash_join_preserves_large_reference` covers the 10M vs 11M case), and
`range_fallback_preserves_target_parallelism` is back to its original assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]