ErikBPF commented on PR #6061: URL: https://github.com/apache/datafusion-comet/pull/6061#issuecomment-6114528693
Thanks, Andy. I reviewed the change and put a runnable demonstration on [a branch of my fork](https://github.com/ErikBPF/datafusion-comet/tree/demo/scalafix-retry-6061), based on this PR's head. [Instructions are here](https://github.com/ErikBPF/datafusion-comet/blob/demo/scalafix-retry-6061/dev/ci/scalafix-resolution-demo.md). The reproducer uses Maven 3.9.6 against a local HTTP repository returning 503. For both Scala 2.12 and 2.13, the short `scalafix:` goal hides the transfer cause behind `No plugin found for prefix 'scalafix'`. Fully qualified goals expose the HTTP 503 while retaining the version from the POM's plugin management. All four cases passed on JDK17 and JDK21. This matters when narrowing the retry condition to recognized transient transfer errors. My recommendations are: - Keep the captured log under `$RUNNER_TEMP`, as @sunchao suggested, so successful runs pass the checkout-cleanliness check. - Retry only recognized transient resolution failures. Compiler and Scalafix errors should fail immediately. - Use fully qualified plugin goals so the retry classifier can see the underlying transfer error. - Declare `shell: bash`, since container steps default to `sh` and the loop uses Bash features. The published branch contains the reproducer and instructions. If this approach looks good to you, I can follow up with the workflow patch and regression coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
