ErikBPF commented on code in PR #6113:
URL: https://github.com/apache/datafusion-comet/pull/6113#discussion_r4243055348
##########
.github/workflows/iceberg_spark_test_reusable.yml:
##########
@@ -224,7 +227,40 @@ jobs:
rm -rf /root/.m2/repository/org/apache/parquet # somehow parquet
cache requires cleanups
ENABLE_COMET=true ENABLE_COMET_ONHEAP=true ./gradlew
-DsparkVersions=${{ inputs.spark-short }} -DscalaVersion=${{ inputs.scala }}
-DflinkVersions= -DkafkaVersions= \
:iceberg-spark:iceberg-spark-extensions-${{ inputs.spark-short
}}_${{ inputs.scala }}:test \
+ --init-script ../dev/ci/iceberg-test-shards.gradle \
Review Comment:
Addressed in `589001e`: extensions distribute across all four shards, while
the core streaming reservation remains intact. The regression fixtures cover
extensions without streaming tests, including small and empty inventories.
Rechecked the current head: all 15 tests in `dev/ci/test-iceberg-shards.py`
and the CI configuration guard passed. The current Comet CI and CodeQL runs are
still awaiting approval. Could a maintainer approve them so the hosted jobs can
verify this head?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
