andygrove opened a new pull request, #6873:
URL: https://github.com/apache/datafusion-comet/pull/6873

   ## Which issue does this PR close?
   
   Closes #6470.
   
   Backport of #6471 to `branch-1.1`.
   
   ## Rationale for this change
   
   Native array element comparisons use raw string bytes and therefore return 
wrong results for non-default Spark collations. The affected expressions must 
dispatch to Spark-compatible comparison logic or fall back. The fix should be 
available in the 1.1 release line.
   
   ## What changes are included in this PR?
   
   Cherry-picks #6471 with `-x`. Collated array comparisons are marked 
incompatible; `array_contains` and `arrays_overlap` use the codegen dispatcher, 
while array-returning set operations fall back. SQL fixtures cover normal, 
disabled-dispatcher, and explicit incompatible-native modes.
   
   The branch-specific adaptation merges the expression documentation with the 
1.1 floating-point notes without importing unrelated main-branch documentation 
changes.
   
   ## How are these changes tested?
   
   With the native library already built, ran:
   
   ```text
   ./mvnw test -Dtest=none -Dsuites='org.apache.comet.CometMapExpressionSuite' 
-Dscalastyle.skip=true
   ```
   
   Result: 1 suite completed, 26 tests passed. The added SQL files also run in 
the existing `CometSqlFileTestSuite` CI matrix.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to