rgbuilds commented on code in PR #26123:
URL: https://github.com/apache/datafusion/pull/26123#discussion_r4240720945
##########
datafusion/core/tests/physical_optimizer/join_selection.rs:
##########
@@ -1969,3 +1971,123 @@ fn test_join_with_maybe_swap_unbounded_case(t:
TestCase) -> Result<()> {
}
Ok(())
}
+
+#[rstest]
Review Comment:
Could we add a regression that lets
`FilterPushdown::new_post_optimization()` create the dynamic filter and
probe-side consumer, then reruns `JoinSelection` and executes the plan? The
current tests correctly exercise both guards, but manually calling
`with_dynamic_filter_expr` does not verify the producer/consumer connection or
query results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
