github-actions[bot] commented on PR #26090: URL: https://github.com/apache/datafusion/pull/26090#issuecomment-6085226818
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-physical-plan v55.1.0 (current) Built [ 36.250s] (current) Parsing datafusion-physical-plan v55.1.0 (current) Parsed [ 0.145s] (current) Building datafusion-physical-plan v55.1.0 (baseline) Built [ 27.706s] (baseline) Parsing datafusion-physical-plan v55.1.0 (baseline) Parsed [ 0.140s] (baseline) Checking datafusion-physical-plan v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.958s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure method_parameter_count_changed: pub method parameter count changed --- Description: A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/method_parameter_count_changed.ron Failed in: datafusion_physical_plan::joins::SortMergeJoinExec::try_new takes 7 parameters in /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/ad995f4dd276695f3b49af03f875b86fea22de77/datafusion/physical-plan/src/joins/sort_merge_join/exec.rs:148, but now takes 8 parameters in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/joins/sort_merge_join/exec.rs:217 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 67.380s] datafusion-physical-plan Building datafusion-proto-models v55.1.0 (current) Built [ 18.543s] (current) Parsing datafusion-proto-models v55.1.0 (current) Parsed [ 0.103s] (current) Building datafusion-proto-models v55.1.0 (baseline) Built [ 18.124s] (baseline) Parsing datafusion-proto-models v55.1.0 (baseline) Parsed [ 0.105s] (baseline) Checking datafusion-proto-models v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 2.613s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_field.ron Failed in: field SortMergeJoinExecNode.null_aware in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:2708 field SortMergeJoinExecNode.null_aware in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:2708 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 41.132s] datafusion-proto-models ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
