Nagato-Yuzuru opened a new pull request, #26086:
URL: https://github.com/apache/datafusion/pull/26086
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Part of #24243
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
Please explain the problem you are trying to solve in terms of the
user-visible
behavior, rather than the implementation.
For example, "The code in `foo.rs` doesn't handle nulls" is a symptom of the
implementation. "COUNT(DISTINCT) returns wrong results when the column
contains
nulls" is the user-visible problem.
-->
The equivalence fuzz tests never generated NULLs. So they could not catch
NULL-ordering bugs in `SortProperties` propagation such as #11596 and #24208.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here, but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- Generated columns contain NULLs at configurable rates (`NULL_PCTS = [0.0,
0.1, 0.5]`), crossed with every seed; the schema is nullable only when the rate
is non-zero.
- `create_random_schema` picks random `SortOptions` for each ordering key.
- Requirements with random `SortOptions` are checked only for soundness: if
`ordering_satisfy` accepts an ordering, the data must be sorted by it. The
converse is not checked, since one batch can be sorted by coincidence (e.g.
NULLs of independent columns landing in the same rows). For the same reason,
`contains_overflowable_arithmetic` is renamed to
`contains_conservative_ordering_op` and also covers comparisons and `AND`/`OR`.
## What is the testing strategy for this PR?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
Briefly describe how this PR is tested, and point to the specific tests you
added. For example: 'This new feature is covered by the `sqllogictest` cases
added in `foo.slt`'.
If this PR does not add tests, explain why. For example, if the change is
already covered by existing tests, please mention it.
You should also check the `codecov` bot reply on this PR to confirm the
changed code is exercised.
-->
Test-only change. Verified locally that reverting the fixes from #24276 and
#24206 makes `test_ordering_satisfy_with_equivalence_complex_random` fail, and
that it passes on main:
```bash
git revert -n ceaef16778f3422312cc1e22ddf40e8f6acda56b
4042812a86f4a753c4b717ecbe12dbc928957254
cargo test -p datafusion --test fuzz --features extended_tests equivalence
# test_ordering_satisfy_with_equivalence_complex_random fails
```
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
