joseph-isaacs commented on issue #25450: URL: https://github.com/apache/datafusion/issues/25450#issuecomment-6018850079
I have been thinking about this change. Are you sure you want this to be a veto instead of a opt-in? If `supports_leaf_expressions` is a allow/veto we need to change the expression and the `TableProvider `/`FileFormat`. Instead why not have `supports_leaf_expressions` be a logical `or` with `ExpressionPlacement` or even remove the placement altogether? (Putting the switch on the TP). If we impl it like this adding expression pushdown required both the expression and TP to agree, this seems like logic only the TP needs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
