andygrove commented on code in PR #4821:
URL: https://github.com/apache/datafusion-comet/pull/4821#discussion_r4178753874
##########
spark/src/main/scala/org/apache/comet/codegen/CometBatchKernelCodegen.scala:
##########
@@ -87,6 +88,7 @@ object CometBatchKernelCodegen extends Logging with
CometExprTraitShim {
case _: StringType | _: BinaryType => true
case DateType | TimestampType | TimestampNTZType => true
case _: YearMonthIntervalType | _: DayTimeIntervalType => true
+ case dt if isTimeType(dt) => true
Review Comment:
Correction to my earlier reply: that gate is gone. Main's codegen dispatcher
now reads TIME inside arrays, structs and maps, so an `array<TIME>` input like
the one in your `transform` example compiles and matches Spark instead of
throwing. This PR no longer touches `CometBatchKernelCodegen`.
##########
docs/source/user-guide/latest/expressions.md:
##########
@@ -278,13 +278,13 @@ The type-name conversion functions (`bigint`, `binary`,
`boolean`, `date`, `deci
| `quarter` | ✅ | |
| `second` | ✅ | |
| `session_window` | 🔜 | Batch session-window grouping falls back
(`UpdatingSessionsExec` is not yet native); tracked by
[#4785](https://github.com/apache/datafusion-comet/issues/4785) |
-| `time_diff` | 🔜 | Spark 4.1 TIME type; tracked by
[#4288](https://github.com/apache/datafusion-comet/issues/4288) |
-| `time_trunc` | 🔜 | Spark 4.1 TIME type; tracked by
[#4288](https://github.com/apache/datafusion-comet/issues/4288) |
+| `time_diff` | ✅ | Spark 4.1+; routes through the JVM codegen dispatcher |
+| `time_trunc` | ✅ | Spark 4.1+; routes through the JVM codegen dispatcher |
| `timestamp_micros` | ✅ | |
| `timestamp_millis` | ✅ | |
| `timestamp_seconds` | ✅ | |
| `to_date` | ✅ | Rewrites to `Cast` (or `Cast(GetTimestamp)` with a format)
before Comet sees the plan |
-| `to_time` | 🔜 | Spark 4.1 TIME type; tracked by
[#4288](https://github.com/apache/datafusion-comet/issues/4288) |
+| `to_time` | ✅ | Spark 4.1+ |
Review Comment:
Correction to my earlier reply: the formatted forms no longer fall back.
Since #5692 they run through the codegen dispatcher, and the `to_time` row now
says so. `try_to_time` has the same support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
