HairstonE commented on issue #25850: URL: https://github.com/apache/datafusion/issues/25850#issuecomment-5982804169
This is already fixed on main. The bug was in `GroupedTopKAggregateStream::intern`, which skipped NULL group keys. It is the same bug as #22554. PR #22571 fixed this. I ran this issue's exact queries against main. Both return the NULL group in the correct position: ``` SELECT DISTINCT x FROM t ORDER BY x LIMIT 10; → -301, 100, 500, NULL SELECT x FROM t GROUP BY x ORDER BY x DESC LIMIT 10; → NULL, 500, 100, -301 ``` The same PR also added regression tests in `aggregates_topk.slt`. An upgrade to 55.0.0 will resolve this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
