andygrove commented on PR #25853: URL: https://github.com/apache/datafusion/pull/25853#issuecomment-5981949099
Addressed the review feedback in b7cd9113c: - @comphead: the `IncrementalSortIterator` docs now say a chunk can be shorter than `batch_size`, `view_bytes` applies the view size rule in one place, and `row_bytes` is now `avg_row_bytes`. The inline suggestions are in the threads. - @2010YOUY01: removed the coalescing of replay output. `external_aggr` against main after these changes: no query is slower, 7 are unchanged and 1 is 1.06x faster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
