samueleresca commented on PR #25917: URL: https://github.com/apache/datafusion/pull/25917#issuecomment-5980840704
Overall, looks good. A minor note. My preference would be to explicitly state the configurations that contribute to security hardening and their default. For example, DuckDB [does something similar](https://duckdb.org/docs/current/operations_manual/securing_duckdb/overview#settings-to-limit-duckdbs-capabilities). Some corresponding examples in the DataFusion domain: - `SQLOptions` and `with_allow_ddl`, `with_allow_dml`, `with_allow_statements` are all allowed by default, as already mentioned. - [SessionContext::enable_url_table](https://docs.rs/datafusion/latest/datafusion/execution/context/struct.SessionContext.html#method.enable_url_table) - No memory limits by default (e.g., [UnboundedMemoryPool](https://docs.rs/datafusion/latest/datafusion/execution/memory_pool/trait.MemoryPool.html#implementing-memorypool)) The stuff above might go in a dedicated section on the already existing [Config page](https://datafusion.apache.org/user-guide/configs.html#). Other notes: - Worth stating that DataFusion relies on other OSS dependencies, and security reports affecting downstream dependencies should be opened in the corresponding repos? - Should the model state explicitly whether `datafusion-cli` is included or not in the model? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
