mrhard9090 commented on PR #26011: URL: https://github.com/apache/datafusion/pull/26011#issuecomment-5976720568
Thanks, @txwyy123. I took the struct extension into this PR (both the scalar and the array path, with the empty-struct guard) and added unit tests for the scalar/array needle, `f32`, the three list types and structs, plus three struct queries in `array_contains.slt`. I have not checked the struct results against a live Spark; the expected values in the tests come from your report and from Spark's NaN equality semantics. The Spark crate's `array_contains` tests, the slt file and clippy with `-D warnings` pass here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
