andygrove opened a new pull request, #6571: URL: https://github.com/apache/datafusion-comet/pull/6571
## Which issue does this PR close? N/A. This is a small release tooling fix discovered while building the 1.1.0 release candidate. ## Rationale for this change `build-release-comet.sh` defaulted to a nonexistent `release` branch and did not discover the problem until after building both uncached Docker images. Release builds should also be pinned to an immutable release candidate tag so the native binaries and final jars come from the same commit. ## What changes are included in this PR? - Require callers to pass a branch or tag with `-b`. - Verify that the exact branch or tag exists in the remote repository before starting Java, Docker, Maven, or cleanup work. - Delay container cleanup activation until the first builder container can exist. - Update the release process to create and push the RC tag before building, check out that tag locally, and pass it to the build script. ## How are these changes tested? - `bash -n dev/release/build-release-comet.sh` - Verified that omitting `-b` fails immediately with usage information. - Verified that a missing remote ref fails immediately with a specific error. - Verified remote lookup of the existing `branch-1.1` branch and `1.1.0-rc1` tag. - `git diff --check origin/main...` A complete multi-architecture release build was not run because the changed behavior exits before the expensive build begins. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
