andygrove opened a new pull request, #6535: URL: https://github.com/apache/datafusion-comet/pull/6535
## Which issue does this PR close? Part of #5639. ## Rationale for this change Issue #5639 proposes splitting `planner.rs` into focused modules before extracting the planner crate. The shuffle writer and shuffle scan planning paths are self-contained and are a natural next step in that decomposition. ## What changes are included in this PR? - Move the `ShuffleWriter` and `ShuffleScan` planning logic into `planner/shuffle.rs`. - Move the shuffle partitioning and writer-destination helpers alongside the builders. - Implement and register `ShuffleWriterBuilder` and `ShuffleScanBuilder` through the operator registry. - Move the shuffle-specific planner tests into the new module and add focused shuffle-scan builder coverage. - Preserve the existing planning and execution behavior unchanged. ## How are these changes tested? - `cargo fmt --all` - `cargo check -p datafusion-comet --all-targets` - `cargo clippy --color=never --all-targets --workspace -- -D warnings` - `DYLD_LIBRARY_PATH="$(/usr/libexec/java_home -v 17)/lib/server" cargo test -p datafusion-comet --lib` (555 passed, 5 ignored) - `make core` - `./mvnw test -Dtest=none -Dsuites="org.apache.spark.sql.comet.execution.shuffle.CometNativeShuffleWriterSuite,org.apache.spark.sql.comet.execution.shuffle.CometNativeShuffleInputRDDSuite,org.apache.comet.exec.CometShuffleSuite"` (52 passed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
