geoffreyclaude commented on code in PR #25186:
URL: https://github.com/apache/datafusion/pull/25186#discussion_r4153289470
##########
datafusion/physical-expr/src/expressions/in_list.rs:
##########
@@ -82,6 +83,20 @@ fn supports_arrow_eq(dt: &DataType) -> bool {
}
}
+fn normalize_in_list_float_zero_value(value: ColumnarValue) -> ColumnarValue {
+ match value {
+ ColumnarValue::Array(array)
+ if dictionary_value_type(array.data_type()).is_floating() =>
Review Comment:
Agreed, I've used your suggested array arm in
93075a5eff83e5d1617f642a46bfb96b3ccc1d7c.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
