s5dsn-eqee commented on code in PR #2576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2576#discussion_r4131331555
##########
src/dialect/mod.rs:
##########
@@ -939,6 +939,7 @@ pub trait Dialect: Debug + Any {
| Token::ExclamationMarkDoubleTilde
| Token::ExclamationMarkDoubleTildeAsterisk
| Token::Spaceship => Ok(p!(Eq)),
+ Token::Overlap if self.supports_double_ampersand_operator() =>
Ok(p!(And)),
Review Comment:
My bad. After looking into it more, I think overriding get_next_precedence
in MySqlDialect would be cleaner, the same way Oracle does for StringConcat:
https://github.com/apache/datafusion-sqlparser-rs/blob/5cad9060d38229ebf22a3b8625c685d5ad8552db/src/dialect/oracle.rs#L88
smt like this
```
fn get_next_precedence(&self, parser: &Parser) -> Option<Result<u8,
ParserError>> {
match parser.peek_token_ref().token {
Token::Overlap => Some(Ok(self.prec_value(Precedence::And))),
_ => None,
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
