NGA-TRAN commented on PR #25815: URL: https://github.com/apache/datafusion/pull/25815#issuecomment-5859265012
Thanks @viirya for a quick response and action. I did some check. Our date_bin input is Timestamp(Nanosecond, None) converted from seconds. The call is date_bin(<interval>, timestamp) on that column directly. We do not pass date_bin a nested expression such as date_trunc. So it seems #25692 would not change our streaming GROUP BY date_bin(...) or sort elimination. #25815 is still the right fix for second, millisecond, and microsecond inputs and for nested expressions. Our timestamps fall in 1970–2106, so the remaining cases where a non-null input becomes NULL (a bin before the type minimum, or a month bin outside DateTime<Utc>) do not apply to us either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
