rluvaton commented on code in PR #25707:
URL: https://github.com/apache/datafusion/pull/25707#discussion_r4115607538
##########
datafusion/physical-plan/src/aggregates/aggregate_hash_table/common.rs:
##########
@@ -80,6 +84,38 @@ pub(in crate::aggregates) fn create_group_accumulator(
}
}
+/// Create an accumulator for `agg_expr` -- a [`BlockedGroupsAccumulator`] if
+/// that is supported by the aggregate, or a
+/// [`BlockedGroupsAccumulatorAdapter`] if not.
+pub(in crate::aggregates) fn create_blocked_group_accumulator(
Review Comment:
this mean I have to duplicate the hash aggregate streams code and I wanted
to avoid this
`GroupsAccumulator` should not be used and should be removed in the end, we
will not release until all `GroupValues` has been converted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
