mixermt commented on PR #6106: URL: https://github.com/apache/datafusion-comet/pull/6106#issuecomment-5856658494
Latest push replaces the derived `Debug` on `FileIoCacheKey` with a manual impl that prints only access mode, catalog name and reference path, with a test asserting the exact output from a key built with vended secrets. The bridge struct doc no longer describes a per-scan lifetime. On measurements: none yet, and I would rather not invent one. `ensureInitialized` caches the provider, so the cache does not remove a second `initialize`. What each task repeated was marshalling the whole catalog bag into a Java map before the JVM cache is reached, four `new_string` calls plus two per property, two thread attaches, two global refs and a fresh `FileIO`. I would rather land this on its own: #5898 is blocked upstream, #6109 has to land in iceberg-rust, and its operator cache only outlives a task if this cache is already in place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
