andygrove opened a new pull request, #2494: URL: https://github.com/apache/datafusion-ballista/pull/2494
# Which issue does this PR close? No separate issue. Split out of #2416 at review request. # Rationale for this change `EXPLAIN` run through Ballista's distributed explain path declared its `plan_type` and `plan` columns nullable. DataFusion's `ExplainExec` (`LogicalPlan::explain_schema`) and Ballista's own `DistributedExplainAnalyzeExec` declare them not-null. A client that checks the schema it was promised against the data it receives, such as ADBC over Flight SQL, sees two different descriptions of the same statement depending on how it was run. Every value unnested here is one of the three plan strings the operator builds itself, so none of them can be null. # What changes are included in this PR? - Declare the unnested `list_type` and `list_plan` columns not-null. - A test that the distributed explain plan's schema, and the schema of the batches it produces, equal `LogicalPlan::explain_schema()`. It fails without the fix. # Are there any user-facing changes? The schema reported for distributed `EXPLAIN` output now marks both columns non-nullable. The data is unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
