alamb commented on PR #2592: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2592#issuecomment-5849471684
I haven't looked at the PR, but the basic idea sounds reasonable COncerns: 1. What will this do to parsing speed (every Box is another allocation) -- we should probably measure that 2. How will downstream crates need to be updated (can they still use `match ...` type statements) I think as long as we have benchmarks that show this doesn't cause (too much) performance regression and a clear upgrade guide it would be good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
