nuno-faria commented on code in PR #25769:
URL: https://github.com/apache/datafusion/pull/25769#discussion_r4112307898
##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -229,22 +227,18 @@ impl<'a> ColumnChecker<'a> {
/// Determine whether the predicate can evaluate as the join conditions
fn can_evaluate_as_join_condition(predicate: &Expr) -> Result<bool> {
- let mut is_evaluate = true;
- predicate.apply(|expr| match expr {
- Expr::Column(_)
- | Expr::Literal(_, _)
- | Expr::Placeholder(_)
- | Expr::ScalarVariable(_, _) => Ok(TreeNodeRecursion::Jump),
Review Comment:
I wonder why `TreeNodeRecursion::Jump` was originally used here. Those
expressions do not have any children, so `TreeNodeRecursion::Continue` should
work the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
