1fanwang commented on PR #25767: URL: https://github.com/apache/datafusion/pull/25767#issuecomment-5847283364
The patch coverage figure here looks like a reporting artifact rather than a real gap, so flagging it in case a reviewer reads the number. In the head report every added line is recorded as zero hits, including unconditional statements such as the first binding in `multiset_set_operation` and the function signatures themselves, which any passing test must execute. The untouched `LogicalPlanBuilder::intersect` is also recorded as zero. The report has `branches` equal to `lines`, so the "partials" count is an llvm-cov region artifact rather than untested branches. The new branches are covered by named tests: - both `min` arms and the NULL grouping: `intersect_all_preserves_duplicate_counts_and_nulls` - matched and unmatched right side (`right_count IS NULL`): `except_all_preserves_duplicate_counts_and_nulls` - the synthetic column-name collision loop: `set_operation_all_preserves_synthetic_column_names` - self-referential requalification: `set_operation_all_with_same_name_from_two_relations` - both Substrait consumer call sites: `multiset_intersect_all_consume` and `primary_except_all_consume` - the unregistered `count`/`range` error for SQL and for both DataFrame methods: `set_operation_all_without_count_or_range_is_a_plan_error` Happy to add more if something genuinely uncovered turns up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
