Abhisheklearn12 commented on issue #25035: URL: https://github.com/apache/datafusion/issues/25035#issuecomment-5844585930
@adriangb I opened a draft for this: #25771 It evaluates `AND` chains as one n-ary conjunction and only pre-selects before conjuncts that are expensive or can fail, so left- and right-deep trees now cost the same. TPC-H Q6, Q12 and Q19 are 9 to 17% faster at SF1 and SF10, and `cardinality_q33_k16` in `predicate_eval` is 2.4× faster. The full numbers are in the PR. Two things I'd like your take on before marking it ready: 1. It removes the `AND` branch of `check_short_circuit` that #22698 edits and models with `and_rhs_evaluation`. Would you rather this land first, or #22698? 2. The contract is that an expensive or fallible conjunct never sees a row that nested evaluation would have skipped. Does that match what you'd expect? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
