rgbuilds commented on PR #25469: URL: https://github.com/apache/datafusion/pull/25469#issuecomment-5843616836
Thanks for adding the three-row-group end-to-end scan case. This addresses my earlier review comment: the revised test now exercises: - an exact-match row group, - a Bloom-pruned row group, and - a crossed-pair row group that survives the derived per-column guarantees but is rejected by the original tuple predicate. I also ran `test_struct_inlist_guarantees` and the `push_down_filter_parquet` SLT locally; both passed. While reviewing the revised guarantee-extraction path, I found a duplicate-field-name case in `named_struct` that appears capable of deriving an invalid necessary guarantee and pruning a row group containing a valid match. I left the concrete counterexample inline. I’m requesting changes pending resolution of that correctness case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
