andygrove opened a new pull request, #6236:
URL: https://github.com/apache/datafusion-comet/pull/6236

   ## Which issue does this PR close?
   
   N/A - this is a release process step for the 1.1.0 release.
   
   ## Rationale for this change
   
   The [release 
process](https://github.com/apache/datafusion-comet/blob/main/docs/source/contributor-guide/release_process.md#update-maven-version)
 requires that the Maven version on the release branch is changed from 
`1.1.0-SNAPSHOT` to `1.1.0` before the release candidate is tagged, so that the 
staged Maven artifacts and the source tarball carry the final release version.
   
   ## What changes are included in this PR?
   
   - Change the Maven version from `1.1.0-SNAPSHOT` to `1.1.0` in `pom.xml`, 
`common/pom.xml`, `spark/pom.xml`, and `spark-integration/pom.xml`.
   - Update `comet.version` in the Spark test diffs (`dev/diffs/3.4.3.diff`, 
`3.5.9.diff`, `4.0.4.diff`, `4.1.3.diff`).
   - Update the `comet` version in the Iceberg diffs 
(`dev/diffs/iceberg/1.8.1.diff`, `1.9.1.diff`, `1.10.0.diff`, `1.11.0.diff`).
   
   The Rust crate versions in `native/Cargo.toml` are already `1.1.0` and do 
not need to change.
   
   The diffs were regenerated from patched Spark and Iceberg checkouts rather 
than edited by hand, so each one also updates the blob hash on the `index` line 
of the file whose version changed (`pom.xml` or `gradle/libs.versions.toml`). 
That is the only other line that changes. Before the change, every existing 
diff regenerated byte-for-byte from its tag, so the regeneration carries no 
unrelated drift.
   
   ## How are these changes tested?
   
   - `git grep -n '1.1.0-SNAPSHOT' -- . ':!docs/source/changelog'` returns no 
hits.
   - `./mvnw validate` passes, and `help:evaluate -Dexpression=project.version` 
reports `1.1.0` for the root, `common`, `spark`, and `spark-integration`.
   - Each new diff applies cleanly to a fresh checkout of its Spark or Iceberg 
tag, and regenerating it from there reproduces the committed file byte-for-byte.
   
   Otherwise existing CI. The Spark SQL and Iceberg workflows are the ones that 
apply these diffs and build against the new version. On a `branch-1.1` pull 
request they run only with the `run-spark-3.4-tests`, `run-spark-3.5-tests`, 
`run-spark-4.0-tests`, `run-spark-4.1-tests` and `run-iceberg-tests` labels.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to