sunchao commented on code in PR #6230: URL: https://github.com/apache/datafusion-comet/pull/6230#discussion_r4107737735
########## spark/src/test/scala/org/apache/spark/sql/comet/CometSessionExtensionsSuite.scala: ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.spark.sql.comet + +import org.apache.spark.sql.{CometTestBase, SparkSessionExtensions} + +import org.apache.comet.CometSparkSessionExtensions +import org.apache.comet.rules.CometRule + +class CometSessionExtensionsSuite extends CometTestBase { Review Comment: [P2] Please register `org.apache.spark.sql.comet.CometSessionExtensionsSuite` in both `.github/workflows/pr_build_linux.yml` and `.github/workflows/pr_build_macos.yml`. Adding this suite without either inventory entry makes `dev/ci/check-suites.py` fail instead of allowing the new tests to run. At this head, that failure turns Preflight and Required Checks red and skips the downstream build/test jobs, blocking CI validation of the change. Evidence: At SHA 74b176784b66b522f675a428eaaa68891c8f5420, `python3 dev/ci/check-suites.py` exits 255 with `Suite not found in workflow .github/workflows/pr_build_linux.yml: org.apache.spark.sql.comet.CometSessionExtensionsSuite`. The class name is absent from both workflow files. Exact-head CI job 108206949972 reports the identical failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
