andygrove opened a new pull request, #6229: URL: https://github.com/apache/datafusion-comet/pull/6229
## Which issue does this PR close? No issue was filed. This is the `branch-1.0` half of #6218, which adds the same guard on `main`. ## Rationale for this change `branch-1.0`'s `ci.yml` runs the `docs` job on `workflow_dispatch`, with no check on the ref. `docs.yaml` builds the checked-out branch's docs, rsyncs them over `asf-site` with `--delete`, and pushes, falling back to `git push --force`. So `gh workflow run ci.yml --ref branch-1.0` would replace the live site with the 1.0 docs. Nobody has dispatched `ci.yml` on `branch-1.0` yet. A dispatch is the only practical way to run the whole suite against this branch. Pull requests to `branch-1.0` skip the Spark SQL suites for Spark 3.4 and 4.0 and the Iceberg suites for 1.8, 1.9 and 1.10 unless labeled, because when the branch was cut those were left to the push-to-`main` run, and this branch's `push` trigger is `main`-only. No `branch-1.0` pull request has carried a `run-*` label, so those five suites have not run against anything merged here since the cut. #6227's run skipped exactly those five. Labeling doesn't help much either: this branch's jobs don't narrow a `labeled` run, so each gating label re-runs the whole pull request pipeline alongside its suite. With this guard in place, one dispatch before the next 1.0.x tag covers them. ## What changes are included in this PR? The `docs` job's `if:` also requires `github.ref == 'refs/heads/main'`, with the comment from #6218. This file only runs for pull requests to `branch-1.0` and dispatches of it (a push to `main` runs `main`'s `ci.yml`), so the deploy no longer runs from this branch at all. ## How are these changes tested? `actionlint` and `python3 dev/ci/check-ci-config.py` pass on the branch. On a pull request the job was already skipped by the event check, and it still is. Only a dispatch exercises the new condition, and a dispatch of `branch-1.0` has `github.ref` set to `refs/heads/branch-1.0`, so the job is skipped. The change is to `.github/workflows/ci.yml`, which every heavy job's path filter includes, so this pull request's own run is the usual full `branch-1.0` matrix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
