neilconway commented on code in PR #25723:
URL: https://github.com/apache/datafusion/pull/25723#discussion_r4100158608
##########
datafusion/functions-aggregate/src/array_agg.rs:
##########
@@ -339,6 +339,20 @@ impl ArrayAggAccumulator {
}
}
+/// Returns the mask of non-null rows in `values` when `ignore_nulls` is set
+/// and some row is null.
+fn non_null_mask(values: &dyn Array, ignore_nulls: bool) ->
Option<BooleanArray> {
Review Comment:
Arrow's `is_not_null` is similar but it would require computing
`logical_nulls()` twice, which it would be nice to avoid doing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
