martin-g commented on code in PR #25005:
URL: https://github.com/apache/datafusion/pull/25005#discussion_r4092662642
##########
datafusion/sql/src/statement.rs:
##########
@@ -1235,6 +1235,10 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
plan_err!("Delete-order-by clause not yet supported")?;
}
+ if limit.is_some() {
+ return not_impl_err!("Delete-limit clause not supported");
Review Comment:
I agree that `NotImplemented` would be the best but the other checks
above/below use PlanningError. IMO it would be better to be consistent.
```suggestion
return plan_err!("Delete-limit clause not yet
supported");
```
##########
datafusion/sqllogictest/test_files/delete.slt:
##########
@@ -141,6 +141,12 @@ physical_plan
01)CooperativeExec
02)--MemDeleteExec: predicate=[CAST(a@0 AS Int64) = 1, b@1 = CAST(2 AS
Utf8View)]
Review Comment:
```suggestion
```
##########
datafusion/sqllogictest/test_files/delete.slt:
##########
@@ -141,6 +141,12 @@ physical_plan
01)CooperativeExec
02)--MemDeleteExec: predicate=[CAST(a@0 AS Int64) = 1, b@1 = CAST(2 AS
Utf8View)]
+statement error This feature is not implemented: Delete-limit clause not
supported
+delete from t1 limit 10;
+
+statement error This feature is not implemented: Delete-limit clause not
supported
Review Comment:
```suggestion
statement error DataFusion error: Error during planning: Delete-limit clause
not yet supported
```
##########
datafusion/sqllogictest/test_files/delete.slt:
##########
@@ -141,6 +141,12 @@ physical_plan
01)CooperativeExec
02)--MemDeleteExec: predicate=[CAST(a@0 AS Int64) = 1, b@1 = CAST(2 AS
Utf8View)]
+statement error This feature is not implemented: Delete-limit clause not
supported
Review Comment:
```suggestion
statement error DataFusion error: Error during planning: Delete-limit clause
not yet supported
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
