xavlee commented on code in PR #24497:
URL: https://github.com/apache/datafusion/pull/24497#discussion_r4086372953
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -1096,6 +1103,15 @@ impl AggregateExec {
input_order_mode = InputOrderMode::Linear;
}
+ let group_completion_mode = if !group_by.has_grouping_set()
Review Comment:
Good catch, I added an explicit PartialReduce guard and extended the test to
check that both ordered and explicitly grouped inputs retain `None`.
I also added a check that we have at least one non-constant expression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
