andygrove commented on PR #5876: URL: https://github.com/apache/datafusion-comet/pull/5876#issuecomment-5796915562
Thanks for keeping this current with main. I ran `./mvnw test-compile -Pspark-3.5 -Pstrict-warnings -DskipTests` on `eaa3f8cfb` since CI hasn't run on it yet. It fails with 10 errors, all in test code that landed on main after the last green run. `-Pspark-3.4` gives the same 10. - `SerdeRegistrationSuite.scala:33-36` warns about an adapted argument list. It needs double parentheses, e.g. `"math" -> ((baseMathExpressions, sparkVersionSpecificMathExpressions))`. - `CometUnixTimestampBenchmark.scala:37,51,60`, `CometParquetWriterSuite.scala:1755`, `CometBinaryLengthBenchmark.scala:60` and `CometIcebergWriteBenchmark.scala:331` are implicit `Int` to `Long` widenings. Could you merge main again, fix these, and run the strict compile locally before pushing? Once that head is up I'll approve the workflow run so the new job gets a real result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
