gabotechs commented on code in PR #4:
URL: https://github.com/apache/datafusion-iceberg/pull/4#discussion_r4060971324
##########
crates/datafusion/src/table/mod.rs:
##########
@@ -97,7 +97,7 @@ impl IcebergTableProvider {
})
}
- pub(crate) async fn metadata_table(
+ pub async fn metadata_table(
Review Comment:
For now, I'd not expose this undocumented method as public.
Forcing users to create an `IcebergMetadataTableProvider` through this
method implies doing two `catalog.load_table()`, one for the
`IcebergTableProvider::try_new` constructor and another one for this method.
A cleaner API would be to expose a `IcebergMetadataTableProvider::try_new()`
method consistent with the one already present in `IcebergTableProvider`, which
does not force users to load the table twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
