andygrove opened a new issue, #6060:
URL: https://github.com/apache/datafusion-comet/issues/6060
### Describe the bug
A transient Maven Central failure in the `Lint Java` matrix is reported as a
lint failure, which
is indistinguishable from a real scalafix violation until someone opens the
log.
In pull request #6035 the `Lint Java (Spark 3.5, JDK 17, Scala 2.12)` job
failed with:
```
[WARNING] Failed to retrieve plugin descriptor for
io.github.evis:scalafix-maven-plugin_2.12:0.1.7_0.10.4:
Plugin io.github.evis:scalafix-maven-plugin_2.12:0.1.7_0.10.4 or one of
its dependencies could not be resolved
[ERROR] No plugin found for prefix 'scalafix' in the current project and in
the plugin groups ...
```
No source file was at fault. The job fails, `Required Checks` goes red, and
the pull request is
blocked until it is pushed again.
### Why it happens
`lint-java`'s `Run scalafix check` step in
`.github/workflows/pr_build_linux.yml` is a single
unguarded `./mvnw ... scalafix:scalafix` invocation. The adjacent
`scalafix-syntactic` job already
treats this class of failure as a first-class concern, and says so in its
own comment: it retries
the artifact download and then runs the check with `--mode offline`, "so a
nonzero exit can only
mean a lint violation, never a download failure". `lint-java` has no
equivalent guard, and
`.github/actions/maven-bootstrap` only covers the Maven distribution
download, not plugin
resolution during the build.
### Expected behaviour
A Maven Central hiccup should be retried rather than reported as a lint
violation. A real scalafix
violation should still fail on the first attempt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
