wudidapaopao commented on PR #25536: URL: https://github.com/apache/datafusion/pull/25536#issuecomment-5749337098
Thanks for running the benchmark. The all-no-change result is expected: the standard TPC-H schema uses Decimal columns, while this PR deliberately limits decomposition to Float64 AVG, so Q1 does not take the new path. This run is useful confirmation that the Decimal path is unchanged. For the optimized path, I materialized the four Q1 Decimal inputs as Float64 Parquet and compared standard release builds on SF1 (14 threads, 58 post-warmup samples per version): - baseline median: 29.137 ms - this PR median: 25.978 ms - improvement: 10.84% I also checked the no-sharing ClickBench Q32 case; it remained effectively unchanged (48.931 ms vs 48.705 ms). Decimal decomposition is intentionally left for a separate design because AVG uses a wider sum state and different result semantics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
