rgbuilds opened a new pull request, #25530:
URL: https://github.com/apache/datafusion/pull/25530

   ## Which issue does this PR close?
   
   Part of #25333 (`CrossJoinExec` test coverage only).
   
   ## Rationale for this change
   
   Join metrics can be incorrect without affecting query results. Existing 
`CrossJoinExec` tests did not assert `build_input_rows` or `input_rows` across 
different input batch layouts.
   
   ## What changes are included in this PR?
   
   Adds Rust test coverage that:
   
   * Verifies `build_input_rows`, `input_rows`, and `output_rows` for the 
existing single-batch case.
   * Runs the same 3 × 2 cross join with input batch sizes of 2 and 1.
   * Confirms the row metrics remain 3, 2, and 6 regardless of input batching.
   
   This is a test-only change.
   
   ## What is the testing strategy for this PR?
   
   ```bash
   cargo fmt --check
   cargo test -p datafusion-physical-plan --lib joins::cross_join
   cargo clippy -p datafusion-physical-plan --all-targets --all-features -- -D 
warnings
   ```
   
   All checks pass locally.
   
   ## Are there any user-facing changes?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to