lxc512157407 commented on PR #24821: URL: https://github.com/apache/datafusion/pull/24821#issuecomment-5738794025
Hi @kumarUjjawal — gentle ping on this one. Since your last review, the approach has been reworked based on @2010YOUY01's feedback: the build-time predicate simplification (and the stats lookup your two comments were about) is gone entirely. The current implementation is a per-batch runtime fast path in FilterExecStream — when the predicate is a bare "col IS NOT NULL" and the batch's column reports null_count == 0, mask evaluation and filter_record_batch are skipped for that batch. Plan shape stays identical to main, so the join regression I reported earlier is resolved. CI still needs a workflow approval to run on dc92a7f06 whenever you have a chance. Happy to make further changes if the current shape still doesn't fit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
