sunchao commented on code in PR #5981:
URL: https://github.com/apache/datafusion-comet/pull/5981#discussion_r4027245908
##########
spark/src/test/scala/org/apache/comet/exec/CometNativeShuffleSuite.scala:
##########
@@ -1153,38 +1153,24 @@ class CometNativeShuffleSuite extends CometTestBase
with AdaptiveSparkPlanHelper
(doubleValue, i)
}
- test("range partitioning on floating-point falls back when
strictFloatingPoint=true") {
- withSQLConf(
- CometConf.COMET_SHUFFLE_NATIVE_RANGE_PARTITIONING_ENABLED.key -> "true",
- CometConf.COMET_EXEC_STRICT_FLOATING_POINT.key -> "true",
- // Bypass the CometSortOrder-level Incompatible check so that only
- // supportedRangePartitioningDataType is exercised as the guard.
- CometConf.getExprAllowIncompatConfigKey("SortOrder") -> "true") {
- withParquetTable(floatingPointRangePartitionData, "tbl") {
- Seq(("FLOAT", "FloatType"), ("DOUBLE", "DoubleType")).foreach {
- case (sqlType, sparkType) =>
+ // The native range partitioner normalizes its comparison keys and its
sampled boundary rows the
+ // same way the native sort does, so scalar floating-point keys match
Spark's ordering whether or
+ // not strict floating point is on. Neither gate needs the allowIncompatible
escape hatch.
+ Seq("true", "false").foreach { strict =>
+ test(
+ s"range partitioning on floating-point uses native shuffle when " +
Review Comment:
### Correctness
[P2] Remove the redundant interpolation prefix to unblock CI
Could you remove the `s` from this first test-name string, keeping it on
`s"strictFloatingPoint=$strict"`? The [current CI lint
job](https://github.com/apache/datafusion-comet/actions/runs/35078547914/job/104827630918)
runs Scalafix 0.14.6 with `RedundantSyntax` and exits 32 with this exact
change as its expected fix. The file is identical at this head and the job's
merge checkout `f445979d`. The Linux workflow feeds `Required Checks`, so this
failure prevents that aggregate check from passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
