ErikBPF commented on PR #5828: URL: https://github.com/apache/datafusion-comet/pull/5828#issuecomment-5647662842
Thanks for the feedback and validation. Addressed the remaining helper duplication in 51f85201d: both `CometHashJoin.doConvert` and `CometBroadcastHashJoinExec.createExec` now use the same protected null-aware join helper. Validation: all 21 focused plan-identity/exchange-reuse cases passed on both Spark 3.5 / Scala 2.12 and Spark 4.1 / Scala 2.13. Spotless, syntactic Scalafix, and whitespace checks passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
