TinyMurky commented on code in PR #25158:
URL: https://github.com/apache/datafusion/pull/25158#discussion_r3995625887
##########
datafusion/physical-plan/src/aggregates/single_stream.rs:
##########
@@ -449,6 +454,27 @@ impl SingleHashAggregateStream {
return Self::break_with_err(e);
}
+ // Soft limit optimization:
Review Comment:
I added documentation to `SingleHashAggregateStream` explaining how the
soft-limit optimization is planned and how early termination works:
https://github.com/apache/datafusion/blob/e92aee75ea5bf774d0dbd6be648849a124c7797e/datafusion/physical-plan/src/aggregates/single_stream.rs#L92-L118
I also changed the field documentation to:
https://github.com/apache/datafusion/blob/e92aee75ea5bf774d0dbd6be648849a124c7797e/datafusion/physical-plan/src/aggregates/single_stream.rs#L136-L138
to
```rust
/// See the "Optimization: DISTINCT LIMIT Soft Limit" section in
/// [`SingleHashAggregateStream`] for details.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
