andygrove commented on PR #5841: URL: https://github.com/apache/datafusion-comet/pull/5841#issuecomment-5635082166
One more heads-up from the merge-queue side, following on from my review above. #5843 (the PR that actually enables the queue, stacked on #5842) changes `POLICY` in `dev/ci/compute-changes.py` so that a `push` to `main` selects only `docs`. Every test job moves to the `merge_group` event instead, because the queue has already tested the exact tree that lands. That will break `test_main_and_manual_runs_include_legacy_consumers` in `dev/ci/test-native-build-selection.py` here, which asserts `event="push"` selects every native consumer. Whichever of #5841 and #5843 lands second needs to update that test (the `workflow_dispatch` half stays true). If this PR lands first, #5843 will pick it up on its rebase along with adding `pr_build_linux_checks` and `build_linux_native` to `required_checks.needs`. If #5843 lands first, the `push` assertion here should become `merge_group`. Also FYI, `run-spark-3.4-tests` and `run-spark-3.5-tests` now exist as labels, so the label-gated selection tests here have real labels behind them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
